D9548: Use minSdk in NotificationsPlugin

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> mtijink wrote in NotificationsPlugin.java:417
> This line shouldn't be removed, as it's a different version check than the other code.

It's already checked before loading the plugin

> mtijink wrote in NotificationsPlugin.java:462
> Why was this version check introduced? That version is already required by the `@RequiresApi` annotation.

As far as I understand the Annotation is just to suppress warnings/show developers that a specific version is needed. We have to make sure ourself that replyToNotification isn't called.

Correct me if I'm wrong

> mtijink wrote in NotificationsPlugin.java:574
> Why Jelly Bean? As I understand the code, it should work with Kitkat.

NotificationListenerService requires 18/JELLY_BEAN_MR2, without this the whole Plugin doesn't make much sense. 20/KITKAT_WATCH is only needed for the reply feature

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D9548

To: nicolasfella, #kde_connect
Cc: mtijink, #kde_connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180103/085e98cd/attachment.html>