D10779: Split MousepadPlugin into X11 and Wayland plugin

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Feb 23 23:43:37 UTC 2018


apol added a comment.


  Would it make sense to have a small input method abstraction class within the plugin?
  
  Would also solve the duplicated plugin issue.

INLINE COMMENTS

> mousepadplugin_wayland.cpp:34
> +
> +enum MouseButtons {
> +    LeftMouseButton = 1,

I'd say it's barely better maintainability when stuff is duplicated.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10779

To: nicolasfella, #kde_connect, graesslin
Cc: apol, graesslin, #kde_connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180223/c042be78/attachment.html>


More information about the KDEConnect mailing list