D10779: Split MousepadPlugin into X11 and Wayland plugin
Nicolas Fella
noreply at phabricator.kde.org
Fri Feb 23 19:47:35 UTC 2018
nicolasfella created this revision.
nicolasfella added reviewers: KDE Connect, graesslin.
nicolasfella added a project: KDE Connect.
nicolasfella requested review of this revision.
REVISION SUMMARY
The MousepadPlugin contains disjoint codepaths to support X11 and Wayland. Split it into two plugins instead of #ifdef'ing for better maintainability.
Currently both plugins are loaded (when compiled). Is there a way to decide whether to load them on runtime? On Android I just would return false in onCreate, but there seems no aquivalent on the desktop.
TEST PLAN
Tested on X and Wayland.
X works fine, Wayland plugin on Wayland too.
X plugin on Wayland crashes, needs to be disabled on runtime.
REPOSITORY
R224 KDE Connect
BRANCH
mousepad
REVISION DETAIL
https://phabricator.kde.org/D10779
AFFECTED FILES
CMakeLists.txt
plugins/CMakeLists.txt
plugins/mousepad/CMakeLists.txt
plugins/mousepad/mousepadplugin.cpp
plugins/mousepad/mousepadplugin.h
plugins/mousepad_wayland/CMakeLists.txt
plugins/mousepad_wayland/README
plugins/mousepad_wayland/config-mousepad.h.cmake
plugins/mousepad_wayland/kdeconnect_mousepad_wayland.json
plugins/mousepad_wayland/mousepadplugin_wayland.cpp
plugins/mousepad_wayland/mousepadplugin_wayland.h
To: nicolasfella, #kde_connect, graesslin
Cc: graesslin, #kde_connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180223/225ff4a1/attachment.html>
More information about the KDEConnect
mailing list