D10703: Build kdeconnect on sailfish and port some simple plugins

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  To be honest I'm not convinced of the whole ifdef gimmick overall. The app barely has any features and it's already riddled, I would expect it to increase. Isn't here a chance to get a Qt 5.9 working there?

INLINE COMMENTS

> CMakeLists.txt:13
>  
> +find_package(PkgConfig)
>  find_package(Qt5 5.2 REQUIRED COMPONENTS Quick)

find also within if(SAILFISHOS)?

> CMakeLists.txt:25
> +else()
> +    set(KF%_MIN_VERSION 5.42.0)
> +    set(KF5_REQUIRED_COMPONENTS I18n ConfigWidgets DBusAddons)

typo

> CMakeLists.txt:24
> +    find_package(KF5Notifications 5.9 REQUIRED)
> +    set(NOTIFICATION_LIB ${NNQT5_LIBRARIES})
> +endif()

Why?

> kdeconnect-sfos.changes.in:1
> +# Rename this file as kdeconnect-sfos.changes to include changelog
> +# entries in your RPM file.

Can you put the RPM stuff within sfos directory?

> kdeconnect-sfos.cpp:59
> +    KdeConnectDeclarativePlugin plugin;
> +    plugin.registerTypes("uk.co.piggz.kdeconnect");
> +    plugin.initializeEngine(view->engine(),"uk.co.piggz.kdeconnect");

Why is it a different import?
Doesn't it make it much harder to share code with the rest?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect, apol
Cc: apol, #kde_connect, nicolasfella, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180221/7f2eae59/attachment.html>