D17126: Privacy Options for Notifications Forwarded to Desktop

[Simon Redman]

sredman accepted this revision.
sredman added a comment.
This revision is now accepted and ready to land.


  Sorry this took so long
  
  I finally had a chance to check, and you are correct. The 'bug' where the notification plugin settings are not per-device is there on the master build too. In that case, it's a problem that should be solved, but not as part of this patch :)
  
  I think this is good work. There is one part that's missing, though. If you notice, when you build from master or you use the Play Store build, then you upgrade to a build with this patch, the app will crash with some error about missing a table. This is because we don't currently have an onUpgrade which handles putting in the new tables, so someone upgrading would have to wipe their app data! This is obviously not great.
  
  There is a solution. If you want to learn about it, look here is the relevant tutorial: https://thebhwgroup.com/blog/how-android-sqlite-onupgrade
  
  I have made a revision which depends on this one: D17521 <https://phabricator.kde.org/D17521>. We can merge that revision right after merging this one, then everything should be working! :)

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  arcpatch-D17126

REVISION DETAIL
  https://phabricator.kde.org/D17126

To: alexkovrigin, sredman, #kde_connect
Cc: sredman, alexkovrigin, kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181212/6e8e3c4f/attachment.html>