D17126: Privacy Options for Notifications Forwarded to Desktop

[Alex Kovrigin]

alexkovrigin added a comment.


  Thanks Simon. This behaviour is logical as AppDatabase is unified and used for every device with NotificationsPligin. And NotificationsPlugin's settings doesn't have any information of connected devices, so there isn't any elegant way of doing things. I see two ways of implementing this:
  
  1. Creating an AppDatabase property for every Device, add a spinner with every remembered device. When selected, the corresponding device's AppDatabase should be updated. For this I will have to somehow provide NotificationsPluginFilter with a list of all devices.
  2. Copying a Notifications Filter List (without any checkboxes) to a menu for every device (like I did at the beginning).
  
  Also, I have noticed, that the task I wanted to claim (write about developing your own plugin), was already taken, I thought it was not 'single-claim' task, I already had an idea for a plugin, but I guess I'll have to work on it after the gci ends.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D17126

To: alexkovrigin, sredman, #kde_connect
Cc: sredman, alexkovrigin, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181201/c186ddb2/attachment.html>