D17411: Use butterknife for view binding
Nicolas Fella
noreply at phabricator.kde.org
Fri Dec 7 19:32:54 GMT 2018
nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.
Looks fine to me. I can't say much to Butterknife, but it seems to work fine
INLINE COMMENTS
> MainActivity.java:56
>
> - private NavigationView mNavigationView;
> - private DrawerLayout mDrawerLayout;
> + @BindView(R.id.navigation_drawer) NavigationView mNavigationView;
> + @BindView(R.id.drawer_layout) DrawerLayout mDrawerLayout;
Any reason why they are not private any more?
REPOSITORY
R225 KDE Connect - Android application
BRANCH
butterknife
REVISION DETAIL
https://phabricator.kde.org/D17411
To: eduisters, #kde_connect, nicolasfella
Cc: nicolasfella, kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181207/259537f5/attachment.html>
More information about the KDEConnect
mailing list