<table><tr><td style="">nicolasfella accepted this revision.<br />nicolasfella added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17411">View Revision</a></tr></table><br /><div><div><p>Looks fine to me. I can't say much to Butterknife, but it seems to work fine</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17411#inline-95406">View Inline</a><span style="color: #4b4d51; font-weight: bold;">MainActivity.java:56</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">private</span></span> <span class="n">NavigationView</span> <span class="n">mNavigationView</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">private</span></span> <span class="n">DrawerLayout</span> <span class="n">mDrawerLayout</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #aa22ff"><span class="bright">@BindView</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">R</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">id</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">navigation_drawer</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">)</span></span> <span class="n">NavigationView</span> <span class="n">mNavigationView</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #aa22ff"><span class="bright">@BindView</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">R</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">id</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">drawer_layout</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">)</span></span> <span class="n">DrawerLayout</span> <span class="n">mDrawerLayout</span><span style="color: #aa2211">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Any reason why they are not private any more?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>BRANCH</strong><div><div>butterknife</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17411">https://phabricator.kde.org/D17411</a></div></div><br /><div><strong>To: </strong>eduisters, KDE Connect, nicolasfella<br /><strong>Cc: </strong>nicolasfella, kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol<br /></div>