D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094)

[Erik Duisters]

eduisters created this revision.
eduisters added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
eduisters requested review of this revision.

REVISION SUMMARY
  When you close a SSLSockets input or output stream the socket does not get closed leading to may
  sockets in the CLOSE_WAIT state. This will eventually deplete the available file descriptors

TEST PLAN
  Before appying this patch share a file from desktop to android
  After the share is finished issue the command:
  
  netstat -pW | grep kde
  
  There should be a line showing that the socket used is in the state CLOSE_WAIT like below
  
  tcp6  0 0 ::ffff:192.168.0.32:33604   ::ffff:192.168.0.2:1739  CLOSE_WAIT  6200/org.kde.kdeconnect_tp
  
  Apply this patch and repeat the test. Now there should no longer be any sockets in the CLOSE_WAIT state

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  sslsocket_close_stream_does_not_close_socket

REVISION DETAIL
  https://phabricator.kde.org/D17320

AFFECTED FILES
  src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java
  src/org/kde/kdeconnect/NetworkPacket.java
  src/org/kde/kdeconnect/Plugins/MprisPlugin/AlbumArtCache.java
  src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java
  src/org/kde/kdeconnect/Plugins/ReceiveNotificationsPlugin/ReceiveNotificationsPlugin.java
  src/org/kde/kdeconnect/Plugins/SharePlugin/ReceiveFileRunnable.java
  src/org/kde/kdeconnect/Plugins/SharePlugin/ShareInfo.java
  src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java

To: eduisters, #kde_connect
Cc: kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181202/7cf46b78/attachment.html>