D15108: Sort Cached Messages

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> conversationsdbusinterface.cpp:71
> +        i++;
> +        if (!(i < end))
> +        {

`i >= end`

> conversationsdbusinterface.h:86
> +     *
> +     * The "List" is actually a QMap of the message timestamp to the actual message body
> +     * so that we can use .values() to get a sorted list of messages

I wouldn't call it a list if it's not a list.
Also would it make sense to have the timestamp in ConversationMessage?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D15108

To: sredman
Cc: apol, nicolasfella, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180828/e44226d8/attachment.html>