D14604: Runner for executing commands on remote device

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in remotecommandsrunner.cpp:50
> const &,
> also this is a blocking dbus call. It would make sense to use the async API.

you're in your own thread here.  Being async doesn't really gain you too much.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D14604

To: nicolasfella, #kde_connect, #plasma, broulik, davidedmundson, apol
Cc: apol, ngraham, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180804/95e3e546/attachment.html>