D14604: Runner for executing commands on remote device

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:90
> +if(KF5Runner_FOUND)
> +    add_subdirectory(runners)
> +endif()

Maybe it would make sense to have a plasma-integration directory with runners and plasmoid?

> remotecommandsrunner.cpp:50
> +
> +        for (QString deviceId : devicesReply.value()) {
> +

const &,
also this is a blocking dbus call. It would make sense to use the async API.

> remotecommandsrunner.cpp:65
> +
> +                QString deviceName = deviceInterface.name();
> +                QString commandName = cont.value(QStringLiteral("name")).toString();

const, and below.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D14604

To: nicolasfella, #kde_connect, #plasma, broulik, davidedmundson, apol
Cc: apol, ngraham, kdeconnect, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180804/5f376338/attachment-0001.html>