D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side)

[Nicolas Fella]

nicolasfella added a comment.


  Test plan should include some steps to reproduce the desired behavior and see what is already implemented and what not

INLINE COMMENTS

> telephonyplugin.cpp:57
> +        Message message(np.body());
> +        this->forwardToTelepathy(message);
> +    }

"->this" is weird, never seen it in a KDE Project

> telephonyplugin.cpp:60
> +
> +    if (np.type() == PACKET_TYPE_TELEPHONY_MESSAGE)
> +    {

Else if?

> telephonyplugin.cpp:108
> +        qCDebug(KDECONNECT_PLUGIN_TELEPHONY) << "Passing a text message to the telepathy interface";
> +        connect(&m_telepathyInterface, SIGNAL(messageReceived(QString,QString)), SLOT(sendSms(QString,QString)), Qt::UniqueConnection);
> +        const QString messageBody = message.getBody();

Use new syntax if possible

> telephonyplugin.cpp:116
> +        } else {
> +            return false;
> +        }

returning false here is not necessary

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D11854

To: sredman, #kde_connect, nicolasfella
Cc: nicolasfella, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180418/6e74cf37/attachment.html>