D12264: Make bluetooth payload upload work & asynchronous

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Apr 17 22:56:39 UTC 2018


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good to me, definitely a step forward.

INLINE COMMENTS

> bluetoothuploadjob.cpp:109
> +
> +void BluetoothUploadJob::onDisconnected() {
> +    closeConnection();

Just connect to closeConnection, let's not add cruft, makes for readability.

REPOSITORY
  R224 KDE Connect

BRANCH
  bluetooth-fix-upload

REVISION DETAIL
  https://phabricator.kde.org/D12264

To: mtijink, #kde_connect, apol
Cc: apol, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180417/1e0c25b2/attachment-0001.html>


More information about the KDEConnect mailing list