D12264: Make bluetooth payload upload work & asynchronous

Matthijs Tijink noreply at phabricator.kde.org
Tue Apr 17 17:01:08 UTC 2018


mtijink marked 3 inline comments as done.
mtijink added a comment.


  I'll do some more testing with the current changes, to make sure edge cases are handled correctly.

INLINE COMMENTS

> apol wrote in bluetoothuploadjob.cpp:107
> If it didn't end we leak?

We'll get called again if more bytes are written, so it eventually either disconnects (when some error happens) or all bytes have been written. Either case, we'll close it and destroy the job.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D12264

To: mtijink, #kde_connect, apol
Cc: apol, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180417/7fcfe171/attachment.html>


More information about the KDEConnect mailing list