Review Request 130116: Fixed Bug in filetransferjob

Nicolas Fella nicolas.fella at gmx.de
Sun May 7 18:16:49 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130116/
-----------------------------------------------------------

(Updated May 7, 2017, 11:16 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit f0010763e7bcf574c6a934ef94552a88968134e9 by Albert Vaca on behalf of Nicolas Fella to branch master.


Repository: kdeconnect-kde


Description
-------

The changes I made in filetransferjob.h for the notification icons broke the file share plugin. Although the file was sent correctly the plasmoid didnt knew the transfer ended. This is now fixed


Diffs
-----

  core/filetransferjob.h e56abf1967032856ad357439a341f5daa9853e2e 
  plugins/notifications/notification.cpp 0e91e10f143d789d943e5fbeecba89032e4eb8b8 

Diff: https://git.reviewboard.kde.org/r/130116/diff/


Testing
-------

All tests pass


Thanks,

Nicolas Fella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170507/557c9f29/attachment.html>


More information about the KDEConnect mailing list