Review Request 130116: Fixed Bug in filetransferjob

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130116/#review103195
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On mai. 6, 2017, 1:36 p.m., Nicolas Fella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130116/
> -----------------------------------------------------------
> 
> (Updated mai. 6, 2017, 1:36 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> The changes I made in filetransferjob.h for the notification icons broke the file share plugin. Although the file was sent correctly the plasmoid didnt knew the transfer ended. This is now fixed
> 
> 
> Diffs
> -----
> 
>   core/filetransferjob.h e56abf1967032856ad357439a341f5daa9853e2e 
>   plugins/notifications/notification.cpp 0e91e10f143d789d943e5fbeecba89032e4eb8b8 
> 
> Diff: https://git.reviewboard.kde.org/r/130116/diff/
> 
> 
> Testing
> -------
> 
> All tests pass
> 
> 
> Thanks,
> 
> Nicolas Fella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170506/54c7c0c9/attachment.html>