Review Request 129980: [kdeconnect-android] Add swipe to refresh to device pairing activity

[Zixing Liu]

> On 三月 15, 2017, 7 p.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/UserInterface/PairingFragment.java, line 273
> > <https://git.reviewboard.kde.org/r/129980/diff/1/?file=492119#file492119line273>
> >
> >     Is this call to updateComputerList really needed? I think it will be called eventually as a callback anyway... Can you see if it still works after removing it?

Yes, it will work. But I did this intentionally, per Android official document, we still need a menu item to assist the user that uses accessibility softwares since these softwares can't describe/perform swipe to refresh very well. And for some users have diffculties swiping to refresh the list (like hands/fingers injury), we still need this menu item to co-exist.


> On 三月 15, 2017, 7 p.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/UserInterface/PairingFragment.java, line 61
> > <https://git.reviewboard.kde.org/r/129980/diff/1/?file=492119#file492119line61>
> >
> >     Don't add whitespaces.

Oops, I will remove this.


> On 三月 15, 2017, 7 p.m., Albert Vaca Cintora wrote:
> > res/layout/activity_refresh_list.xml, lines 6-7
> > <https://git.reviewboard.kde.org/r/129980/diff/1/?file=492118#file492118line6>
> >
> >     The two xmlns: and tools: lines should be in the topmost element.

I will modify this per your request.


> On 三月 15, 2017, 7 p.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/UserInterface/PairingFragment.java, line 64
> > <https://git.reviewboard.kde.org/r/129980/diff/1/?file=492119#file492119line64>
> >
> >     menuProgress is now unused, remove it from here and from the menu XML.

I will fix this per your request.


- Zixing


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129980/#review102865
-----------------------------------------------------------


On 三月 2, 2017, 11:11 p.m., Zixing Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129980/
> -----------------------------------------------------------
> 
> (Updated 三月 2, 2017, 11:11 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Add swipe to refresh to device pairing activity
> 
> This makes it more conform to material design standard
> 
> 
> Diffs
> -----
> 
>   res/layout/activity_refresh_list.xml PRE-CREATION 
>   src/org/kde/kdeconnect/UserInterface/PairingFragment.java c5fe622 
> 
> Diff: https://git.reviewboard.kde.org/r/129980/diff/
> 
> 
> Testing
> -------
> 
> Built and tested thoroughly on an Android 7.1.1 (API Level 25) device
> 
> 
> Thanks,
> 
> Zixing Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170316/c7bd3725/attachment.html>