Review Request 129980: [kdeconnect-android] Add swipe to refresh to device pairing activity

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129980/#review102865
-----------------------------------------------------------



A very similar view to this one is used when you select a device after using the "Share" functionality in Android (see src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java). Maybe you can change it there as well?


res/layout/activity_refresh_list.xml (lines 6 - 7)
<https://git.reviewboard.kde.org/r/129980/#comment68495>

    The two xmlns: and tools: lines should be in the topmost element.



src/org/kde/kdeconnect/UserInterface/PairingFragment.java (line 61)
<https://git.reviewboard.kde.org/r/129980/#comment68493>

    Don't add whitespaces.



src/org/kde/kdeconnect/UserInterface/PairingFragment.java (line 64)
<https://git.reviewboard.kde.org/r/129980/#comment68492>

    menuProgress is now unused, remove it from here and from the menu XML.



src/org/kde/kdeconnect/UserInterface/PairingFragment.java (line 273)
<https://git.reviewboard.kde.org/r/129980/#comment68494>

    Is this call to updateComputerList really needed? I think it will be called eventually as a callback anyway... Can you see if it still works after removing it?


- Albert Vaca Cintora


On mar. 2, 2017, 3:11 p.m., Zixing Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129980/
> -----------------------------------------------------------
> 
> (Updated mar. 2, 2017, 3:11 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Add swipe to refresh to device pairing activity
> 
> This makes it more conform to material design standard
> 
> 
> Diffs
> -----
> 
>   res/layout/activity_refresh_list.xml PRE-CREATION 
>   src/org/kde/kdeconnect/UserInterface/PairingFragment.java c5fe622 
> 
> Diff: https://git.reviewboard.kde.org/r/129980/diff/
> 
> 
> Testing
> -------
> 
> Built and tested thoroughly on an Android 7.1.1 (API Level 25) device
> 
> 
> Thanks,
> 
> Zixing Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170315/ecd4862f/attachment-0001.html>