D6089: Show no notification icon if there is no

[Albert Vaca Cintora]

albertvaka added inline comments.

INLINE COMMENTS

> nicolasfella wrote in notification.cpp:105
> setIconName("none") is different to setIconName("").
> Also the use of QStringLiteral is right here https://woboq.com/blog/qstringliteral.html

setIconName("none") will try to find an icon named "none". Will display nothing because there is no icon with that name. The proper way of not displaying an icon is to set it to empty string, that is QString().

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6089

To: nicolasfella, #kde_connect
Cc: albertvaka, apol, #kde_connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170622/ce9ffa1a/attachment.html>