D6089: Show no notification icon if there is no

Nicolas Fella noreply at phabricator.kde.org
Thu Jun 8 11:34:17 UTC 2017


nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in notification.cpp:105
> `QString()`?

setIconName("none") is different to setIconName("").
Also the use of QStringLiteral is right here https://woboq.com/blog/qstringliteral.html

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6089

To: nicolasfella, #kde_connect
Cc: apol, #kde_connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170608/24eabb93/attachment.html>


More information about the KDEConnect mailing list