D7993: WIP: System volume plugin Android

[Nicolas Fella]

nicolasfella added a comment.


  In https://phabricator.kde.org/D7993#181551, @mtijink wrote:
  
  > Looks ok to me (and it works). But why is this implemented as a separate plugin?
  
  
  First I had it as part of the MPRIS Plugin but I decided to put it into a separate plugin because of the following reasons:
  
  - pactl or even pulseaudio could not be available
  - either the desktop or the client part could not be up to date and lack the required code
  
  Both would require a lot of conditional code inside the MPRIS Plugin that handles all those cases. If we have separate plugins we just check those conditions when loading the plugins and enable/disable the systemvolume plugin. Also the functionality is quite disjoint (althought of course somewhat related) so a separate plugin is more clear and maintainable. They only share an UI, but in my current work I encapsulate the UI parts into a own Fragment that can be easily moved to/reused at other places.
  
  > I think it needs to be able to see the current volume (also after volume changes, so maybe libpulse is required anyway) to be really useful, though.
  
  That's why it's work in progress :)
  
  I think I can publish my current work soon-ish

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7993

To: nicolasfella, #kde_connect
Cc: mtijink, #kde_connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20171220/93d612e2/attachment.html>