D7993: WIP: System volume plugin Android

[Matthijs Tijink]

mtijink added a comment.


  Looks ok to me (and it works). But why is this implemented as a separate plugin?
  
  I think it needs to be able to see the current volume (also after volume changes, so maybe libpulse is required anyway) to be really useful, though.

INLINE COMMENTS

> MprisActivity.java:418
>  
> +        ((SeekBar)findViewById(R.id.systemvolume_seek)).setOnSeekBarChangeListener(new SeekBar.OnSeekBarChangeListener() {
> +            @Override

Some code should be added to hide the "set system volume" controls if the plugin is not available.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7993

To: nicolasfella, #kde_connect
Cc: mtijink, #kde_connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20171220/7be5eca6/attachment-0001.html>