D7312: Make member variable names, & placement and * placement more coherent

[Jean Vincent]

jeanv updated this revision to Diff 18304.
jeanv added a comment.


  Reverted the erroneous renaming of d-pointers. And properly renamed a few missing member variables

REPOSITORY
  R224 KDE Connect

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7312?vs=18167&id=18304

REVISION DETAIL
  https://phabricator.kde.org/D7312

AFFECTED FILES
  app/main.cpp
  app/org.kde.kdeconnect.app.desktop
  cli/kdeconnect-cli.cpp
  core/backends/bluetooth/bluetoothdownloadjob.cpp
  core/backends/bluetooth/bluetoothdownloadjob.h
  core/backends/bluetooth/bluetoothuploadjob.cpp
  core/backends/bluetooth/bluetoothuploadjob.h
  core/backends/devicelinereader.cpp
  core/backends/devicelinereader.h
  core/backends/devicelink.cpp
  core/backends/devicelink.h
  core/backends/lan/downloadjob.cpp
  core/backends/lan/downloadjob.h
  core/backends/lan/landevicelink.cpp
  core/backends/lan/landevicelink.h
  core/backends/lan/lanlinkprovider.cpp
  core/backends/lan/lanlinkprovider.h
  core/backends/lan/server.cpp
  core/backends/lan/socketlinereader.cpp
  core/backends/lan/socketlinereader.h
  core/backends/lan/uploadjob.cpp
  core/backends/lan/uploadjob.h
  core/backends/pairinghandler.cpp
  core/core_debug.cpp
  core/daemon.cpp
  core/daemon.h
  core/device.cpp
  core/device.h
  core/filetransferjob.cpp
  core/filetransferjob.h
  core/kdeconnectconfig.cpp
  core/kdeconnectconfig.h
  core/kdeconnectplugin.cpp
  core/kdeconnectpluginconfig.cpp
  core/networkpackage.cpp
  core/networkpackage.h
  core/pluginloader.cpp
  core/pluginloader.h
  daemon/kdeconnect.desktop
  daemon/kdeconnectd.desktop.cmake
  fileitemactionplugin/kdeconnectsendfile.desktop
  fileitemactionplugin/sendfileitemaction.cpp
  fileitemactionplugin/sendfileitemaction.h
  indicator/deviceindicator.h
  indicator/main.cpp
  indicator/org.kde.kdeconnect.nonplasma.desktop
  interfaces/dbusinterfaces.cpp
  interfaces/dbusinterfaces.h
  interfaces/devicesmodel.cpp
  interfaces/devicesmodel.h
  interfaces/devicessortproxymodel.cpp
  interfaces/devicessortproxymodel.h
  interfaces/modeltest.cpp
  interfaces/modeltest.h
  interfaces/notificationsmodel.cpp
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm_kdeconnect.desktop
  kcm/org.kde.kdeconnect.kcm.desktop
  kcmplugin/kdeconnectpluginkcm.cpp
  kio/kiokdeconnect.cpp
  kio/kiokdeconnect.h
  plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp
  plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.h
  plasmoid/declarativeplugin/objectfactory.h
  plasmoid/declarativeplugin/processrunner.cpp
  plasmoid/declarativeplugin/processrunner.h
  plasmoid/declarativeplugin/responsewaiter.h
  plasmoid/package/metadata.desktop
  plugins/battery/batterydbusinterface.cpp
  plugins/battery/batterydbusinterface.h
  plugins/battery/batteryplugin.cpp
  plugins/battery/batteryplugin.h
  plugins/battery/kdeconnect_battery.json
  plugins/clipboard/clipboardplugin.cpp
  plugins/clipboard/clipboardplugin.h
  plugins/clipboard/kdeconnect_clipboard.json
  plugins/findmyphone/findmyphoneplugin.h
  plugins/findmyphone/kdeconnect_findmyphone.json
  plugins/kdeconnect.notifyrc
  plugins/kdeconnect_plugin.desktop
  plugins/lockdevice/kdeconnect_lockdevice.json
  plugins/lockdevice/lockdeviceplugin.h
  plugins/mousepad/kdeconnect_mousepad.json
  plugins/mousepad/mousepadplugin.cpp
  plugins/mousepad/mousepadplugin.h
  plugins/mousepad_windows/kdeconnect_mousepad.json
  plugins/mousepad_windows/mousepadplugin_windows.h
  plugins/mpriscontrol/kdeconnect_mpriscontrol.json
  plugins/mpriscontrol/mpriscontrolplugin.h
  plugins/mprisremote/kdeconnect_mprisremote.json
  plugins/mprisremote/mprisremoteplugin.h
  plugins/notifications/kdeconnect_notifications.json
  plugins/notifications/notification.cpp
  plugins/notifications/notification.h
  plugins/notifications/notificationsdbusinterface.cpp
  plugins/notifications/notificationsdbusinterface.h
  plugins/notifications/notificationsplugin.h
  plugins/notifications/sendreplydialog.cpp
  plugins/notifications/sendreplydialog.h
  plugins/pausemusic/kdeconnect_pausemusic.json
  plugins/pausemusic/kdeconnect_pausemusic_config.desktop
  plugins/pausemusic/pausemusic_config.cpp
  plugins/pausemusic/pausemusic_config.h
  plugins/pausemusic/pausemusicplugin.h
  plugins/ping/kdeconnect_ping.json
  plugins/ping/pingplugin.h
  plugins/remotecommands/kdeconnect_remotecommands.json
  plugins/remotecommands/remotecommandsplugin.cpp
  plugins/remotecommands/remotecommandsplugin.h
  plugins/remotecontrol/kdeconnect_remotecontrol.json
  plugins/remotecontrol/remotecontrolplugin.cpp
  plugins/remotecontrol/remotecontrolplugin.h
  plugins/remotekeyboard/kdeconnect_remotekeyboard.json
  plugins/remotekeyboard/remotekeyboardplugin.h
  plugins/runcommand/kdeconnect_runcommand.json
  plugins/runcommand/kdeconnect_runcommand_config.desktop
  plugins/runcommand/runcommand_config.cpp
  plugins/runcommand/runcommand_config.h
  plugins/runcommand/runcommandplugin.h
  plugins/screensaver-inhibit/kdeconnect_screensaver_inhibit.json
  plugins/screensaver-inhibit/screensaverinhibitplugin.h
  plugins/sendnotifications/kdeconnect_sendnotifications.json
  plugins/sendnotifications/kdeconnect_sendnotifications_config.desktop
  plugins/sendnotifications/notificationslistener.cpp
  plugins/sendnotifications/notificationslistener.h
  plugins/sendnotifications/notifyingapplication.cpp
  plugins/sendnotifications/notifyingapplication.h
  plugins/sendnotifications/notifyingapplicationmodel.cpp
  plugins/sendnotifications/notifyingapplicationmodel.h
  plugins/sendnotifications/sendnotifications_config.cpp
  plugins/sendnotifications/sendnotifications_config.h
  plugins/sendnotifications/sendnotificationsplugin.h
  plugins/sftp/kdeconnect_sftp.json
  plugins/sftp/mounter.h
  plugins/sftp/sftpplugin.cpp
  plugins/sftp/sftpplugin.h
  plugins/share/kdeconnect_share.json
  plugins/share/kdeconnect_share_config.desktop
  plugins/share/share_config.cpp
  plugins/share/share_config.h
  plugins/share/shareplugin.h
  plugins/telephony/kdeconnect_telephony.json
  plugins/telephony/sendsmsdialog.cpp
  plugins/telephony/sendsmsdialog.h
  plugins/telephony/telephonyplugin.cpp
  plugins/telephony/telephonyplugin.h
  tests/downloadjobtest.cpp
  tests/lanlinkprovidertest.cpp
  tests/networkpackagetests.cpp
  tests/pluginloadtest.cpp
  tests/sendfiletest.cpp
  tests/testnotificationlistener.cpp
  tests/testsocketlinereader.cpp
  tests/testsslsocketlinereader.cpp
  urlhandler/org.kde.kdeconnect.telhandler.desktop

To: jeanv, #kde_connect, nicolasfella, albertvaka
Cc: albertvaka, #kde_connect, jeanv, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, apol, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170817/fbeea116/attachment-0001.html>