<table><tr><td style="">jeanv updated this revision to Diff 18304.<br />jeanv added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7312" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Reverted the erroneous renaming of d-pointers. And properly renamed a few missing member variables</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D7312?vs=18167&id=18304" rel="noreferrer">https://phabricator.kde.org/D7312?vs=18167&id=18304</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7312" rel="noreferrer">https://phabricator.kde.org/D7312</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>app/main.cpp<br />
app/org.kde.kdeconnect.app.desktop<br />
cli/kdeconnect-cli.cpp<br />
core/backends/bluetooth/bluetoothdownloadjob.cpp<br />
core/backends/bluetooth/bluetoothdownloadjob.h<br />
core/backends/bluetooth/bluetoothuploadjob.cpp<br />
core/backends/bluetooth/bluetoothuploadjob.h<br />
core/backends/devicelinereader.cpp<br />
core/backends/devicelinereader.h<br />
core/backends/devicelink.cpp<br />
core/backends/devicelink.h<br />
core/backends/lan/downloadjob.cpp<br />
core/backends/lan/downloadjob.h<br />
core/backends/lan/landevicelink.cpp<br />
core/backends/lan/landevicelink.h<br />
core/backends/lan/lanlinkprovider.cpp<br />
core/backends/lan/lanlinkprovider.h<br />
core/backends/lan/server.cpp<br />
core/backends/lan/socketlinereader.cpp<br />
core/backends/lan/socketlinereader.h<br />
core/backends/lan/uploadjob.cpp<br />
core/backends/lan/uploadjob.h<br />
core/backends/pairinghandler.cpp<br />
core/core_debug.cpp<br />
core/daemon.cpp<br />
core/daemon.h<br />
core/device.cpp<br />
core/device.h<br />
core/filetransferjob.cpp<br />
core/filetransferjob.h<br />
core/kdeconnectconfig.cpp<br />
core/kdeconnectconfig.h<br />
core/kdeconnectplugin.cpp<br />
core/kdeconnectpluginconfig.cpp<br />
core/networkpackage.cpp<br />
core/networkpackage.h<br />
core/pluginloader.cpp<br />
core/pluginloader.h<br />
daemon/kdeconnect.desktop<br />
daemon/kdeconnectd.desktop.cmake<br />
fileitemactionplugin/kdeconnectsendfile.desktop<br />
fileitemactionplugin/sendfileitemaction.cpp<br />
fileitemactionplugin/sendfileitemaction.h<br />
indicator/deviceindicator.h<br />
indicator/main.cpp<br />
indicator/org.kde.kdeconnect.nonplasma.desktop<br />
interfaces/dbusinterfaces.cpp<br />
interfaces/dbusinterfaces.h<br />
interfaces/devicesmodel.cpp<br />
interfaces/devicesmodel.h<br />
interfaces/devicessortproxymodel.cpp<br />
interfaces/devicessortproxymodel.h<br />
interfaces/modeltest.cpp<br />
interfaces/modeltest.h<br />
interfaces/notificationsmodel.cpp<br />
kcm/kcm.cpp<br />
kcm/kcm.h<br />
kcm/kcm_kdeconnect.desktop<br />
kcm/org.kde.kdeconnect.kcm.desktop<br />
kcmplugin/kdeconnectpluginkcm.cpp<br />
kio/kiokdeconnect.cpp<br />
kio/kiokdeconnect.h<br />
plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp<br />
plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.h<br />
plasmoid/declarativeplugin/objectfactory.h<br />
plasmoid/declarativeplugin/processrunner.cpp<br />
plasmoid/declarativeplugin/processrunner.h<br />
plasmoid/declarativeplugin/responsewaiter.h<br />
plasmoid/package/metadata.desktop<br />
plugins/battery/batterydbusinterface.cpp<br />
plugins/battery/batterydbusinterface.h<br />
plugins/battery/batteryplugin.cpp<br />
plugins/battery/batteryplugin.h<br />
plugins/battery/kdeconnect_battery.json<br />
plugins/clipboard/clipboardplugin.cpp<br />
plugins/clipboard/clipboardplugin.h<br />
plugins/clipboard/kdeconnect_clipboard.json<br />
plugins/findmyphone/findmyphoneplugin.h<br />
plugins/findmyphone/kdeconnect_findmyphone.json<br />
plugins/kdeconnect.notifyrc<br />
plugins/kdeconnect_plugin.desktop<br />
plugins/lockdevice/kdeconnect_lockdevice.json<br />
plugins/lockdevice/lockdeviceplugin.h<br />
plugins/mousepad/kdeconnect_mousepad.json<br />
plugins/mousepad/mousepadplugin.cpp<br />
plugins/mousepad/mousepadplugin.h<br />
plugins/mousepad_windows/kdeconnect_mousepad.json<br />
plugins/mousepad_windows/mousepadplugin_windows.h<br />
plugins/mpriscontrol/kdeconnect_mpriscontrol.json<br />
plugins/mpriscontrol/mpriscontrolplugin.h<br />
plugins/mprisremote/kdeconnect_mprisremote.json<br />
plugins/mprisremote/mprisremoteplugin.h<br />
plugins/notifications/kdeconnect_notifications.json<br />
plugins/notifications/notification.cpp<br />
plugins/notifications/notification.h<br />
plugins/notifications/notificationsdbusinterface.cpp<br />
plugins/notifications/notificationsdbusinterface.h<br />
plugins/notifications/notificationsplugin.h<br />
plugins/notifications/sendreplydialog.cpp<br />
plugins/notifications/sendreplydialog.h<br />
plugins/pausemusic/kdeconnect_pausemusic.json<br />
plugins/pausemusic/kdeconnect_pausemusic_config.desktop<br />
plugins/pausemusic/pausemusic_config.cpp<br />
plugins/pausemusic/pausemusic_config.h<br />
plugins/pausemusic/pausemusicplugin.h<br />
plugins/ping/kdeconnect_ping.json<br />
plugins/ping/pingplugin.h<br />
plugins/remotecommands/kdeconnect_remotecommands.json<br />
plugins/remotecommands/remotecommandsplugin.cpp<br />
plugins/remotecommands/remotecommandsplugin.h<br />
plugins/remotecontrol/kdeconnect_remotecontrol.json<br />
plugins/remotecontrol/remotecontrolplugin.cpp<br />
plugins/remotecontrol/remotecontrolplugin.h<br />
plugins/remotekeyboard/kdeconnect_remotekeyboard.json<br />
plugins/remotekeyboard/remotekeyboardplugin.h<br />
plugins/runcommand/kdeconnect_runcommand.json<br />
plugins/runcommand/kdeconnect_runcommand_config.desktop<br />
plugins/runcommand/runcommand_config.cpp<br />
plugins/runcommand/runcommand_config.h<br />
plugins/runcommand/runcommandplugin.h<br />
plugins/screensaver-inhibit/kdeconnect_screensaver_inhibit.json<br />
plugins/screensaver-inhibit/screensaverinhibitplugin.h<br />
plugins/sendnotifications/kdeconnect_sendnotifications.json<br />
plugins/sendnotifications/kdeconnect_sendnotifications_config.desktop<br />
plugins/sendnotifications/notificationslistener.cpp<br />
plugins/sendnotifications/notificationslistener.h<br />
plugins/sendnotifications/notifyingapplication.cpp<br />
plugins/sendnotifications/notifyingapplication.h<br />
plugins/sendnotifications/notifyingapplicationmodel.cpp<br />
plugins/sendnotifications/notifyingapplicationmodel.h<br />
plugins/sendnotifications/sendnotifications_config.cpp<br />
plugins/sendnotifications/sendnotifications_config.h<br />
plugins/sendnotifications/sendnotificationsplugin.h<br />
plugins/sftp/kdeconnect_sftp.json<br />
plugins/sftp/mounter.h<br />
plugins/sftp/sftpplugin.cpp<br />
plugins/sftp/sftpplugin.h<br />
plugins/share/kdeconnect_share.json<br />
plugins/share/kdeconnect_share_config.desktop<br />
plugins/share/share_config.cpp<br />
plugins/share/share_config.h<br />
plugins/share/shareplugin.h<br />
plugins/telephony/kdeconnect_telephony.json<br />
plugins/telephony/sendsmsdialog.cpp<br />
plugins/telephony/sendsmsdialog.h<br />
plugins/telephony/telephonyplugin.cpp<br />
plugins/telephony/telephonyplugin.h<br />
tests/downloadjobtest.cpp<br />
tests/lanlinkprovidertest.cpp<br />
tests/networkpackagetests.cpp<br />
tests/pluginloadtest.cpp<br />
tests/sendfiletest.cpp<br />
tests/testnotificationlistener.cpp<br />
tests/testsocketlinereader.cpp<br />
tests/testsslsocketlinereader.cpp<br />
urlhandler/org.kde.kdeconnect.telhandler.desktop</div></div></div><br /><div><strong>To: </strong>jeanv, KDE Connect, nicolasfella, albertvaka<br /><strong>Cc: </strong>albertvaka, KDE Connect, jeanv, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, apol, hkaelberer<br /></div>