D7312: Make member variable names, & placement and * placement more coherent

[Albert Vaca Cintora]

albertvaka requested changes to this revision.
albertvaka added a comment.
This revision now requires changes to proceed.


  I see some inconsistencies, for example in `DaemonPrivate` you changed 
  `QSet<LinkProvider*> mLinkProviders;` to
   `QSet<LinkProvider*> m_linkProviders;`
  
  while in `KdeConnectPluginPrivate` you changed
   `Device* mDevice;` to
   `Device* device; `
  
  Also, I see you renamed d-pointers (https://wiki.qt.io/D-Pointer) like `QScopedPointer<KdeConnectPluginPrivate> d;` to `QScopedPointer<KdeConnectPluginPrivate> m_pluginInfos;` and we should keep the naming so it is clear we are using this programming pattern.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7312

To: jeanv, #kde_connect, nicolasfella, albertvaka
Cc: albertvaka, #kde_connect, jeanv, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, apol, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170816/8c52bcf6/attachment.html>