D7312: Make member variable names, & placement and * placement more coherent

[Jean Vincent]

jeanv created this revision.
jeanv added a project: KDE Connect.

REVISION SUMMARY
  Change all member variables to the form m_fooBar because it is the preferred form in Qt (it was half and half between this and mFooBar, and a minority didn't have anything).
  Place all references and pointers on the side of the type since it is the majority.
  
  Basically:
  
  - mFoo -> m_foo
  - foo -> m_foo (if it is a member variable)
  - Type &ref -> Type& ref
  - Type *ptr -> Type* ptr

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7312

AFFECTED FILES
  app/main.cpp
  cli/kdeconnect-cli.cpp
  core/backends/bluetooth/bluetoothdownloadjob.cpp
  core/backends/bluetooth/bluetoothdownloadjob.h
  core/backends/bluetooth/bluetoothuploadjob.cpp
  core/backends/bluetooth/bluetoothuploadjob.h
  core/backends/devicelinereader.cpp
  core/backends/devicelinereader.h
  core/backends/devicelink.cpp
  core/backends/devicelink.h
  core/backends/lan/downloadjob.cpp
  core/backends/lan/downloadjob.h
  core/backends/lan/landevicelink.cpp
  core/backends/lan/landevicelink.h
  core/backends/lan/lanlinkprovider.cpp
  core/backends/lan/lanlinkprovider.h
  core/backends/lan/server.cpp
  core/backends/lan/socketlinereader.cpp
  core/backends/lan/socketlinereader.h
  core/backends/lan/uploadjob.cpp
  core/backends/lan/uploadjob.h
  core/backends/pairinghandler.cpp
  core/core_debug.cpp
  core/daemon.cpp
  core/daemon.h
  core/device.cpp
  core/device.h
  core/filetransferjob.cpp
  core/filetransferjob.h
  core/kdeconnectconfig.cpp
  core/kdeconnectconfig.h
  core/kdeconnectplugin.cpp
  core/kdeconnectplugin.h
  core/kdeconnectpluginconfig.cpp
  core/kdeconnectpluginconfig.h
  core/networkpackage.cpp
  core/networkpackage.h
  core/pluginloader.cpp
  core/pluginloader.h
  fileitemactionplugin/sendfileitemaction.cpp
  fileitemactionplugin/sendfileitemaction.h
  indicator/deviceindicator.h
  indicator/main.cpp
  interfaces/dbusinterfaces.cpp
  interfaces/dbusinterfaces.h
  interfaces/devicesmodel.cpp
  interfaces/devicesmodel.h
  interfaces/devicessortproxymodel.cpp
  interfaces/devicessortproxymodel.h
  interfaces/modeltest.cpp
  interfaces/modeltest.h
  interfaces/notificationsmodel.cpp
  kcm/kcm.cpp
  kcm/kcm.h
  kcmplugin/kdeconnectpluginkcm.cpp
  kcmplugin/kdeconnectpluginkcm.h
  kio/kiokdeconnect.cpp
  kio/kiokdeconnect.h
  plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp
  plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.h
  plasmoid/declarativeplugin/objectfactory.h
  plasmoid/declarativeplugin/processrunner.cpp
  plasmoid/declarativeplugin/processrunner.h
  plasmoid/declarativeplugin/responsewaiter.h
  plugins/battery/batterydbusinterface.cpp
  plugins/battery/batterydbusinterface.h
  plugins/battery/batteryplugin.cpp
  plugins/battery/batteryplugin.h
  plugins/clipboard/clipboardplugin.cpp
  plugins/clipboard/clipboardplugin.h
  plugins/findmyphone/findmyphoneplugin.h
  plugins/lockdevice/lockdeviceplugin.h
  plugins/mousepad/mousepadplugin.cpp
  plugins/mousepad/mousepadplugin.h
  plugins/mousepad_windows/mousepadplugin_windows.h
  plugins/mpriscontrol/mpriscontrolplugin.h
  plugins/mprisremote/mprisremoteplugin.h
  plugins/notifications/notification.cpp
  plugins/notifications/notification.h
  plugins/notifications/notificationsdbusinterface.cpp
  plugins/notifications/notificationsdbusinterface.h
  plugins/notifications/notificationsplugin.h
  plugins/notifications/sendreplydialog.cpp
  plugins/notifications/sendreplydialog.h
  plugins/pausemusic/pausemusic_config.cpp
  plugins/pausemusic/pausemusic_config.h
  plugins/pausemusic/pausemusicplugin.h
  plugins/ping/pingplugin.h
  plugins/remotecommands/remotecommandsplugin.cpp
  plugins/remotecommands/remotecommandsplugin.h
  plugins/remotecontrol/remotecontrolplugin.cpp
  plugins/remotecontrol/remotecontrolplugin.h
  plugins/remotekeyboard/remotekeyboardplugin.h
  plugins/runcommand/runcommand_config.cpp
  plugins/runcommand/runcommand_config.h
  plugins/runcommand/runcommandplugin.h
  plugins/screensaver-inhibit/screensaverinhibitplugin.h
  plugins/sendnotifications/notificationslistener.cpp
  plugins/sendnotifications/notificationslistener.h
  plugins/sendnotifications/notifyingapplication.cpp
  plugins/sendnotifications/notifyingapplication.h
  plugins/sendnotifications/notifyingapplicationmodel.cpp
  plugins/sendnotifications/notifyingapplicationmodel.h
  plugins/sendnotifications/sendnotifications_config.cpp
  plugins/sendnotifications/sendnotifications_config.h
  plugins/sendnotifications/sendnotificationsplugin.h
  plugins/sftp/mounter.h
  plugins/sftp/sftpplugin.cpp
  plugins/sftp/sftpplugin.h
  plugins/share/share_config.cpp
  plugins/share/share_config.h
  plugins/share/shareplugin.h
  plugins/telephony/sendsmsdialog.cpp
  plugins/telephony/sendsmsdialog.h
  plugins/telephony/telephonyplugin.cpp
  plugins/telephony/telephonyplugin.h
  tests/downloadjobtest.cpp
  tests/lanlinkprovidertest.cpp
  tests/networkpackagetests.cpp
  tests/pluginloadtest.cpp
  tests/sendfiletest.cpp
  tests/testnotificationlistener.cpp
  tests/testsocketlinereader.cpp
  tests/testsslsocketlinereader.cpp

To: jeanv, #kde_connect
Cc: #kde_connect, jeanv, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, apol, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170814/0b10064c/attachment.html>