Review Request 128939: Implement flashlight flashing in FinMyPhone plugin

[Łukasz Żarnowiecki]

> On Wrz 19, 2016, 2:40 rano, Aleix Pol Gonzalez wrote:
> > AndroidManifest.xml, line 30
> > <https://git.reviewboard.kde.org/r/128939/diff/1/?file=477121#file477121line30>
> >
> >     I find it a bit odd to extend KDE Connect permissions to camera for the feature.

If you want to have an access to flashlight, you need to have this permission.  I understand that it might be weird that kind of application wants to have an access to the camera, but this is really a cool feature.  The phone could be much more easily located if you see the strobe light somewhere in the room and if someone is concerned about camera abuse he or she can study the code.  This is really not evil thing.

Also the camera permission could be further use to implement other features.

* remote shutter
* streaming video from camera
* using camera in your computer as a normal device
* ... and more


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128939/#review99265
-----------------------------------------------------------


On Wrz 18, 2016, 10:19 po południu, Łukasz Żarnowiecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128939/
> -----------------------------------------------------------
> 
> (Updated Wrz 18, 2016, 10:19 po południu)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> I think this a really nice feature when trying to find a phone.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml fdfb80b 
>   src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java 2c565bf 
> 
> Diff: https://git.reviewboard.kde.org/r/128939/diff/
> 
> 
> Testing
> -------
> 
> Yes, Android 5.1
> 
> 
> Thanks,
> 
> Łukasz Żarnowiecki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160919/e1160639/attachment.html>