Review Request 128939: Implement flashlight flashing in FinMyPhone plugin

Mon Sep 19 02:40:59 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128939/#review99265
-----------------------------------------------------------


AndroidManifest.xml (line 30)
<https://git.reviewboard.kde.org/r/128939/#comment66842>

    I find it a bit odd to extend KDE Connect permissions to camera for the feature.


- Aleix Pol Gonzalez


On Sept. 19, 2016, 12:19 a.m., Łukasz Żarnowiecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128939/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 12:19 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> I think this a really nice feature when trying to find a phone.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml fdfb80b 
>   src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java 2c565bf 
> 
> Diff: https://git.reviewboard.kde.org/r/128939/diff/
> 
> 
> Testing
> -------
> 
> Yes, Android 5.1
> 
> 
> Thanks,
> 
> Łukasz Żarnowiecki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160919/41643f2b/attachment-0001.html>