Review changes for commit to kdeconnect-android.git

[Albert Vaca]

Sounds good. In Cyanogen, what if there are no commands configured? We
shouldn't show an empty list... Maybe it can just launch kdeconnect in that
case?

You can add me as reviewer (albertvaka at gmail.com).

On Wed, Nov 16, 2016 at 11:08 PM, Jesus Mena <menasshock at gmail.com> wrote:

> Hi every one,
>
> Reading the android 7+ tiles api, I see that the api only support a custom
> tile, not a list inside a tile(like WiFi), so, I will implement the next
> behavior:
>
> 1. when the user OS is AOSP based(non cyanogenmod), the tile will be a
> short cut to KDEConnect, only a icon indicating the disponibility of a
> valid connection to a KDEConnect server; the icon will be on or off.
>
> 2. If the user OS is Cyanogenmod, aditionally, the icon will show a
> sublist of available commands(necessarely commands?) on the KDEConnect
> server currently connected.
>
> -
>
> Aditionally, When I upload a diff to phabricator, it ask to me for a
> reviewer,
> who is that reviewer?
>
> Gracias / Thanks :D
> Jesus
>
>
> Gracias.
> Jesus Mena
>
> 2016-11-16 5:48 GMT-05:00 Albert Vaca <albertvaka at gmail.com>:
>
>> ReviewBoard still works, but apparently every KDE project will have to
>> move to Phabricator eventually. So yes.
>>
>> On Nov 16, 2016 08:20, "Holger Kaelberer" <hk at elberer.de> wrote:
>>
>>>
>>>
>>> On 11/15/2016 08:13 PM, Albert Vaca wrote:
>>>
>>> Please use Phabricator to send patches: https://phabricator.kde.org/di
>>>> fferential/diff/create/
>>>>
>>>
>>> So phabricator shall be used from now on instead of
>>> https://git.reviewboard.kde.org for RR?
>>>
>>> Holger
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20161117/27194c98/attachment.html>