Review Request 128269: Introduce QVariantMap as an argument of NetworkPackage

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128269/#review96783
-----------------------------------------------------------


Ship it!




I'm fine adopting C++11 stuff and I like the more compact syntax. I'm a bit afraid it might be confusing for people new to C++, but let's give it a shot. 

Just note, though, that unfortunately the implementation of the initializer_list constructor [1] is not faster than what we had before. So we are doing this only *because C++11*.

[1] https://github.com/qtproject/qtbase/blob/dev/src/corelib/tools/qmap.h#L336


plugins/mpriscontrol/mpriscontrolplugin.cpp (line 284)
<https://git.reviewboard.kde.org/r/128269/#comment65366>

    This might be too much, though :P


- Albert Vaca Cintora


On jun. 21, 2016, 4:58 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128269/
> -----------------------------------------------------------
> 
> (Updated jun. 21, 2016, 4:58 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Makes it possible to specify the different properties sent at once, rather than one by one as we used to do.
> 
> Also port whenever possible to the initializer-list syntax.
> 
> Disclaimer: This is a late-night airport hack.
> 
> 
> Diffs
> -----
> 
>   core/backends/lan/landevicelink.h 8aa1c79 
>   core/backends/lan/landevicelink.cpp 14b8510 
>   core/backends/lan/lanpairinghandler.cpp fbe5ebd 
>   core/backends/lan/uploadjob.cpp 4810813 
>   core/networkpackage.h b1bf107 
>   core/networkpackage.cpp 570c2d2 
>   plugins/battery/batteryplugin.cpp 732c3a4 
>   plugins/clipboard/clipboardplugin.cpp 656dc72 
>   plugins/lockdevice/lockdeviceplugin.cpp d486260 
>   plugins/mpriscontrol/mpriscontrolplugin.cpp c83ffb0 
>   plugins/mprisremote/mprisremoteplugin.cpp b2e669a 
>   plugins/notifications/notificationsdbusinterface.cpp 471aae5 
>   plugins/notifications/notificationsplugin.cpp 5cc281d 
>   plugins/remotecommands/remotecommandsplugin.cpp 95d5285 
>   plugins/remotecontrol/remotecontrolplugin.cpp 3b20569 
>   plugins/runcommand/runcommandplugin.cpp 8f071b1 
>   plugins/sendnotifications/notificationslistener.cpp f907de6 
>   plugins/sftp/mounter.cpp a77ed4d 
>   plugins/telepathy/telepathyplugin.cpp ef4f0e1 
>   plugins/telephony/telephonyplugin.cpp 84a3c30 
> 
> Diff: https://git.reviewboard.kde.org/r/128269/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160621/13575015/attachment.html>