<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128269/">https://git.reviewboard.kde.org/r/128269/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm fine adopting C++11 stuff and I like the more compact syntax. I'm a bit afraid it might be confusing for people new to C++, but let's give it a shot.
Just note, though, that unfortunately the implementation of the initializer_list constructor [1] is not faster than what we had before. So we are doing this only *because C++11*.
[1] https://github.com/qtproject/qtbase/blob/dev/src/corelib/tools/qmap.h#L336</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128269/diff/1/?file=469676#file469676line286" style="color: black; font-weight: bold; text-decoration: underline;">plugins/mpriscontrol/mpriscontrolplugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">282</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">NetworkPackage</span> <span class="n">np</span><span class="p">(</span><span class="n">PACKAGE_TYPE_MPRIS</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">284</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">NetworkPackage</span> <span class="n">np</span><span class="p">(</span><span class="n">PACKAGE_TYPE_MPRIS</span><span class="p">,</span> <span class="n">QVariantMap</span><span class="p">{{</span><span class="s">"playerList"</span><span class="p">,</span> <span class="n">QVariant</span><span class="o">::</span><span class="n">fromValue</span><span class="p">(</span><span class="n">playerList</span><span class="p">.</span><span class="n">keys</span><span class="p">())}});</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This might be too much, though :P</pre>
</div>
</div>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On juny 21st, 2016, 4:58 a.m. PDT, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated jun. 21, 2016, 4:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes it possible to specify the different properties sent at once, rather than one by one as we used to do.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also port whenever possible to the initializer-list syntax.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Disclaimer: This is a late-night airport hack.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, tests still pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/backends/lan/landevicelink.h <span style="color: grey">(8aa1c79)</span></li>
<li>core/backends/lan/landevicelink.cpp <span style="color: grey">(14b8510)</span></li>
<li>core/backends/lan/lanpairinghandler.cpp <span style="color: grey">(fbe5ebd)</span></li>
<li>core/backends/lan/uploadjob.cpp <span style="color: grey">(4810813)</span></li>
<li>core/networkpackage.h <span style="color: grey">(b1bf107)</span></li>
<li>core/networkpackage.cpp <span style="color: grey">(570c2d2)</span></li>
<li>plugins/battery/batteryplugin.cpp <span style="color: grey">(732c3a4)</span></li>
<li>plugins/clipboard/clipboardplugin.cpp <span style="color: grey">(656dc72)</span></li>
<li>plugins/lockdevice/lockdeviceplugin.cpp <span style="color: grey">(d486260)</span></li>
<li>plugins/mpriscontrol/mpriscontrolplugin.cpp <span style="color: grey">(c83ffb0)</span></li>
<li>plugins/mprisremote/mprisremoteplugin.cpp <span style="color: grey">(b2e669a)</span></li>
<li>plugins/notifications/notificationsdbusinterface.cpp <span style="color: grey">(471aae5)</span></li>
<li>plugins/notifications/notificationsplugin.cpp <span style="color: grey">(5cc281d)</span></li>
<li>plugins/remotecommands/remotecommandsplugin.cpp <span style="color: grey">(95d5285)</span></li>
<li>plugins/remotecontrol/remotecontrolplugin.cpp <span style="color: grey">(3b20569)</span></li>
<li>plugins/runcommand/runcommandplugin.cpp <span style="color: grey">(8f071b1)</span></li>
<li>plugins/sendnotifications/notificationslistener.cpp <span style="color: grey">(f907de6)</span></li>
<li>plugins/sftp/mounter.cpp <span style="color: grey">(a77ed4d)</span></li>
<li>plugins/telepathy/telepathyplugin.cpp <span style="color: grey">(ef4f0e1)</span></li>
<li>plugins/telephony/telephonyplugin.cpp <span style="color: grey">(84a3c30)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128269/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>