Review Request 128149: RFC: Move the Telepathy infrastructure at the plugin level

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128149/#review96489
-----------------------------------------------------------



well, this won't work at all.

Plugins are loaded on demand when it finds a phone with the service.

KTp will see that it can't find the service. It can't autostart the service..and therefore assume the account is broken. 

Hence the comment about why we need to register the telepathy service in main so that it's always available.

- David Edmundson


On June 10, 2016, 2:43 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128149/
> -----------------------------------------------------------
> 
> (Updated June 10, 2016, 2:43 p.m.)
> 
> 
> Review request for kdeconnect and David Edmundson.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> At the moment, telepathy integration needs to be compiled within the daemon. This creates a rather aggressive dependency with Telepathy.
> 
> This plugin proposes to move into a plugin, so that if the plugin isn't present, telepathy becomes out of the picture.
> 
> David: I'm not really sure how well it's going to work, I'm relying on your feedback on how to proceed.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b778ff9 
>   daemon/CMakeLists.txt 359ea8d 
>   daemon/kdeconnectd.cpp 180cc53 
>   plugins/telephony/telephonyplugin.cpp d285c39 
> 
> Diff: https://git.reviewboard.kde.org/r/128149/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160614/ed8f7290/attachment.html>