Review Request 128149: RFC: Move the Telepathy infrastructure at the plugin level

Aleix Pol Gonzalez aleixpol at kde.org
Fri Jun 10 14:43:54 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128149/
-----------------------------------------------------------

Review request for kdeconnect and David Edmundson.


Repository: kdeconnect-kde


Description
-------

At the moment, telepathy integration needs to be compiled within the daemon. This creates a rather aggressive dependency with Telepathy.

This plugin proposes to move into a plugin, so that if the plugin isn't present, telepathy becomes out of the picture.

David: I'm not really sure how well it's going to work, I'm relying on your feedback on how to proceed.


Diffs
-----

  CMakeLists.txt b778ff9 
  daemon/CMakeLists.txt 359ea8d 
  daemon/kdeconnectd.cpp 180cc53 
  plugins/telephony/telephonyplugin.cpp d285c39 

Diff: https://git.reviewboard.kde.org/r/128149/diff/


Testing
-------

Builds


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160610/ba9348b8/attachment.html>


More information about the KDEConnect mailing list