Review Request 126830: [GCI] Adjust the touchpad sensitivity

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126830/#review91393
-----------------------------------------------------------



I don't think 5 options are too many. Actually with a slider we would have more.


src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java (line 81)
<https://git.reviewboard.kde.org/r/126830/#comment62471>

    Passing a string and doing a switch on it every time seems like unnecessary overhead. Why don't you just do the switch once and store the multiplier (ie: 0.2, 0.5, 1...) instead?


- Albert Vaca Cintora


On Jan. 20, 2016, 11:58 a.m., Imran Tatriev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126830/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 11:58 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Hi, I've adjusted the touchpad sensitivity ;)
> 
> 1) Are you sure we need 5 cases? Maybe we can use just 3: Slow, Default, Fast. What do you think about it?
> 2) Also, if you're ok with current changes, after GCI ending (3-4 days) I can improve the approach and maybe use sliders instead of list elements?
> 
> Thanks.
> 
> 
> Diffs
> -----
> 
>   res/values/strings.xml 062ed6ce9fbfcbff58d2448bc95ff2f4b79cc83c 
>   res/xml/mousepadplugin_preferences.xml 9f0c2daf9f95f0f7be400fe719688c033251a9fd 
>   src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java 043b66db3da6ae9274dfb3e437c564e7ba6ab632 
>   src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java f293a4fff496134439ebb66088314521632ce323 
> 
> Diff: https://git.reviewboard.kde.org/r/126830/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> ccc.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/20/c77b2058-a1a6-4834-ba2e-928b71cc2715__ccc.png
> ccc1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/20/c5e2759c-6e66-400f-9fa5-b082dea72263__ccc1.png
> 
> 
> Thanks,
> 
> Imran Tatriev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160121/7d7dac34/attachment.html>