<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126830/">https://git.reviewboard.kde.org/r/126830/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think 5 options are too many. Actually with a slider we would have more.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126830/diff/1/?file=435005#file435005line81" style="color: black; font-weight: bold; text-decoration: underline;">src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kd">public</span> <span class="kt">void</span> <span class="nf">sendMouseDelta</span><span class="o">(</span><span class="kt">float</span> <span class="n">dx</span><span class="o">,</span> <span class="kt">float</span> <span class="n">dy</span><span class="o">)</span> <span class="o">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kd">public</span> <span class="kt">void</span> <span class="nf">sendMouseDelta</span><span class="o">(</span><span class="kt">float</span> <span class="n">dx</span><span class="o">,</span> <span class="kt">float</span> <span class="n">dy</span><span class="o"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">String</span></span><span class="hl"> </span><span class="n"><span class="hl">sensitivity</span></span><span class="o">)</span> <span class="o">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Passing a string and doing a switch on it every time seems like unnecessary overhead. Why don't you just do the switch once and store the multiplier (ie: 0.2, 0.5, 1...) instead?</pre>
</div>
</div>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On January 20th, 2016, 11:58 a.m. PST, Imran Tatriev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Albert Vaca Cintora.</div>
<div>By Imran Tatriev.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2016, 11:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, I've adjusted the touchpad sensitivity ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Are you sure we need 5 cases? Maybe we can use just 3: Slow, Default, Fast. What do you think about it?
2) Also, if you're ok with current changes, after GCI ending (3-4 days) I can improve the approach and maybe use sliders instead of list elements?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>res/values/strings.xml <span style="color: grey">(062ed6ce9fbfcbff58d2448bc95ff2f4b79cc83c)</span></li>
<li>res/xml/mousepadplugin_preferences.xml <span style="color: grey">(9f0c2daf9f95f0f7be400fe719688c033251a9fd)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java <span style="color: grey">(043b66db3da6ae9274dfb3e437c564e7ba6ab632)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java <span style="color: grey">(f293a4fff496134439ebb66088314521632ce323)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126830/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/20/c77b2058-a1a6-4834-ba2e-928b71cc2715__ccc.png">ccc.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/20/c5e2759c-6e66-400f-9fa5-b082dea72263__ccc1.png">ccc1.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>