Review Request 126645: notifications: don't register proxied notifications internally
Albert Vaca Cintora
albertvaka at gmail.com
Thu Jan 7 11:28:08 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126645/#review90744
-----------------------------------------------------------
Ship it!
- Albert Vaca Cintora
On gen. 5, 2016, 12:25 p.m., Holger Kaelberer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126645/
> -----------------------------------------------------------
>
> (Updated gen. 5, 2016, 12:25 p.m.)
>
>
> Review request for kdeconnect.
>
>
> Repository: kdeconnect-kde
>
>
> Description
> -------
>
> The internally maintained notifications are meant only for notifications received from remote peers. Currently we also store local notifications that are proxied to remote.
>
>
> Diffs
> -----
>
> plugins/notifications/notificationslistener.cpp c5f9563
> tests/testnotificationlistener.cpp b80d864
>
> Diff: https://git.reviewboard.kde.org/r/126645/diff/
>
>
> Testing
> -------
>
> yes, locally caught notifications no longer show up in the plasmoid
>
>
> Thanks,
>
> Holger Kaelberer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160107/4c668927/attachment.html>
More information about the KDEConnect
mailing list