Review Request 126645: notifications: don't register proxied notifications internally

Holger Kaelberer holger.k at elberer.de
Tue Jan 5 20:25:46 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126645/
-----------------------------------------------------------

(Updated Jan. 5, 2016, 8:25 p.m.)


Review request for kdeconnect.


Changes
-------

updated tests: can't spy on dbusInterface anymore :-(


Repository: kdeconnect-kde


Description
-------

The internally maintained notifications are meant only for notifications received from remote peers. Currently we also store local notifications that are proxied to remote.


Diffs (updated)
-----

  plugins/notifications/notificationslistener.cpp c5f9563 
  tests/testnotificationlistener.cpp b80d864 

Diff: https://git.reviewboard.kde.org/r/126645/diff/


Testing
-------

yes, locally caught notifications no longer show up in the plasmoid


Thanks,

Holger Kaelberer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160105/575dc85a/attachment.html>


More information about the KDEConnect mailing list