Review Request 127769: Remove second UDP socket in LanLinkProvider

David Kahles david.kahles96 at gmail.com
Fri Apr 29 15:29:41 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127769/
-----------------------------------------------------------

(Updated April 29, 2016, 3:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit abc5fa3c56c5f45d5ba13d6ed577ce10870d7141 by David Kahles to branch sslrefactor.


Repository: kdeconnect-kde


Description
-------

We don't need two sockets for reading and writing. I can't imagine the reason for this, sending and recieving should be possible from the same socket.
This is https://git.reviewboard.kde.org/r/127642/ recreated on branch sslrefactor.


Diffs
-----

  core/backends/lan/lanlinkprovider.h 033877db97a3460387686881d9d89cec5139104f 
  core/backends/lan/lanlinkprovider.cpp 03f429cf50ddf80e7f7a18ed45ea53731c118300 

Diff: https://git.reviewboard.kde.org/r/127769/diff/


Testing
-------

Device discovery, pairing and unpairing still works as before.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160429/8d1c5504/attachment.html>


More information about the KDEConnect mailing list