Review Request 127769: Remove second UDP socket in LanLinkProvider

Aleix Pol Gonzalez aleixpol at kde.org
Thu Apr 28 23:19:20 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127769/#review95001
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On April 27, 2016, 8:41 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127769/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 8:41 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> We don't need two sockets for reading and writing. I can't imagine the reason for this, sending and recieving should be possible from the same socket.
> This is https://git.reviewboard.kde.org/r/127642/ recreated on branch sslrefactor.
> 
> 
> Diffs
> -----
> 
>   core/backends/lan/lanlinkprovider.h 033877db97a3460387686881d9d89cec5139104f 
>   core/backends/lan/lanlinkprovider.cpp 03f429cf50ddf80e7f7a18ed45ea53731c118300 
> 
> Diff: https://git.reviewboard.kde.org/r/127769/diff/
> 
> 
> Testing
> -------
> 
> Device discovery, pairing and unpairing still works as before.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160428/01641542/attachment.html>


More information about the KDEConnect mailing list