Review Request 127611: Fix mpris player discovery

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127611/#review94432
-----------------------------------------------------------



Just for future reference, this bug was introduced here [1] but it seemed to work back then. Maybe a change in Qt 5.6 made this API behave differently?

[1] https://git.reviewboard.kde.org/r/123637/

- Albert Vaca Cintora


On April 8, 2016, 2:39 a.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127611/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 2:39 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> The previous used QDbusServiceWatcher doesn't work as it does only watch out
> for specific services, but the players use different, unpredictable names, so
> we need to check all service registrations for mpris players.
> 
> BUG: 361367
> 
> 
> Diffs
> -----
> 
>   plugins/mpriscontrol/mpriscontrolplugin.h e7839eba99cb3d918c1741c3e226a4da878cdc59 
>   plugins/mpriscontrol/mpriscontrolplugin.cpp cc2fcde972ea224d68a332b563c0b0c97adf47eb 
> 
> Diff: https://git.reviewboard.kde.org/r/127611/diff/
> 
> 
> Testing
> -------
> 
> Previously, new launched players were not found, and quiting a player was unrecognized.
> Now all players are recognized. I tested starting them before launching kdeconnectd and launching and quiting them when kdeconnectd is running.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160408/0e2862fd/attachment.html>