Review Request 127611: Fix mpris player discovery

[David Kahles]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127611/
-----------------------------------------------------------

(Updated April 8, 2016, 9:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 337dd191e459011faae2f1b8a27a5760ad996e70 by David Kahles to branch master.


Repository: kdeconnect-kde


Description
-------

The previous used QDbusServiceWatcher doesn't work as it does only watch out
for specific services, but the players use different, unpredictable names, so
we need to check all service registrations for mpris players.

BUG: 361367


Diffs
-----

  plugins/mpriscontrol/mpriscontrolplugin.h e7839eba99cb3d918c1741c3e226a4da878cdc59 
  plugins/mpriscontrol/mpriscontrolplugin.cpp cc2fcde972ea224d68a332b563c0b0c97adf47eb 

Diff: https://git.reviewboard.kde.org/r/127611/diff/


Testing
-------

Previously, new launched players were not found, and quiting a player was unrecognized.
Now all players are recognized. I tested starting them before launching kdeconnectd and launching and quiting them when kdeconnectd is running.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160408/c2a70706/attachment.html>