Review Request 127583: Introduce QML component to check for plugin availability

[David Kahles]

> On April 6, 2016, 5:30 p.m., Aleix Pol Gonzalez wrote:
> > plasmoid/package/contents/ui/FindMyPhone.qml, line 30
> > <https://git.reviewboard.kde.org/r/127583/diff/1/?file=455648#file455648line30>
> >
> >     readonly to all 3?

"deviceId" can't be readonly because we need to asign it in DeviceDelegate.qml.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127583/#review94334
-----------------------------------------------------------


On April 7, 2016, 8:47 a.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127583/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 8:47 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Remove those checks from three different places and put them into a reusable
> component, which can be used for different plugins.
> 
> 
> Diffs
> -----
> 
>   plasmoid/package/contents/ui/Battery.qml 4538437b9ef0c70c743c673b5256ea95d11f18c3 
>   plasmoid/package/contents/ui/FindMyPhone.qml 8a666b7bcf56ffb1b3bf1823bbf36dedcfd3a969 
>   plasmoid/package/contents/ui/PluginChecker.qml PRE-CREATION 
>   plasmoid/package/contents/ui/Sftp.qml 9ef4f41765d3bd51a4609850ee8f02d7f2eb2bba 
> 
> Diff: https://git.reviewboard.kde.org/r/127583/diff/
> 
> 
> Testing
> -------
> 
> Enabling and disabling the sftp, battery and findmyphone plugin in the KCM works fine.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160407/8ffd20ea/attachment-0001.html>