Review Request 127583: Introduce QML component to check for plugin availability
David Kahles
david.kahles96 at gmail.com
Thu Apr 7 06:47:16 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127583/
-----------------------------------------------------------
(Updated April 7, 2016, 8:47 a.m.)
Review request for kdeconnect.
Changes
-------
Make "device" and "available" aliases readonly.
Repository: kdeconnect-kde
Description
-------
Remove those checks from three different places and put them into a reusable
component, which can be used for different plugins.
Diffs (updated)
-----
plasmoid/package/contents/ui/Battery.qml 4538437b9ef0c70c743c673b5256ea95d11f18c3
plasmoid/package/contents/ui/FindMyPhone.qml 8a666b7bcf56ffb1b3bf1823bbf36dedcfd3a969
plasmoid/package/contents/ui/PluginChecker.qml PRE-CREATION
plasmoid/package/contents/ui/Sftp.qml 9ef4f41765d3bd51a4609850ee8f02d7f2eb2bba
Diff: https://git.reviewboard.kde.org/r/127583/diff/
Testing
-------
Enabling and disabling the sftp, battery and findmyphone plugin in the KCM works fine.
Thanks,
David Kahles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160407/debd6254/attachment.html>
More information about the KDEConnect
mailing list