Review Request 127542: Stop clearing the notification list twice

David Kahles david.kahles96 at gmail.com
Tue Apr 5 21:34:20 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127542/
-----------------------------------------------------------

(Updated April 5, 2016, 9:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit a8bd062baf15356975a76bd84b48afc5d5d3540a by David Kahles to branch master.


Repository: kdeconnect-kde


Description
-------

There were two clearNotifications() calls when refreshing the notification
list. As there happens nothing relevant in between them, the second call is
useless.


Diffs
-----

  interfaces/notificationsmodel.cpp 20d242e3d7b19b0cc6e14f88135f77c5df4018a2 

Diff: https://git.reviewboard.kde.org/r/127542/diff/


Testing
-------

None, i don't expect problems with this patch.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160405/ad229258/attachment.html>


More information about the KDEConnect mailing list