Review Request 127542: Stop clearing the notification list twice

Aleix Pol Gonzalez aleixpol at kde.org
Fri Apr 1 15:07:10 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127542/#review94186
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On April 1, 2016, 3:40 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127542/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 3:40 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> There were two clearNotifications() calls when refreshing the notification
> list. As there happens nothing relevant in between them, the second call is
> useless.
> 
> 
> Diffs
> -----
> 
>   interfaces/notificationsmodel.cpp 20d242e3d7b19b0cc6e14f88135f77c5df4018a2 
> 
> Diff: https://git.reviewboard.kde.org/r/127542/diff/
> 
> 
> Testing
> -------
> 
> None, i don't expect problems with this patch.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160401/23af4649/attachment.html>


More information about the KDEConnect mailing list