Review Request 125388: do not runtime require Qt 5.5 for no good reason

Harald Sitter sitter at kde.org
Fri Sep 25 09:04:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125388/
-----------------------------------------------------------

(Updated Sept. 25, 2015, 9:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 66743cf11fc73f1bb5b26d9d6cbc123a9da00581 by Harald Sitter to branch master.


Repository: kdeconnect-kde


Description
-------

Layouts 1.2 appeared in Qt 5.5 [1] and introduced new fooMargin properties
[2]. We do however not use margins here, so we do not actually need
Layouts 1.2. Drop back down to Layouts 1.1 to be more compatible with
mainstream distros.

[1] http://doc.qt.io/qt-5.4/qtquick-layouts-qmlmodule.html
[2] http://doc.qt.io/qt-5.5/qml-qtquick-layouts-layout.html#bottomMargin-attached-prop


Diffs
-----

  plasmoid/package/contents/ui/DeviceDelegate.qml bcc4fbc23f6d0058ca32f4be74c836bf76263f21 

Diff: https://git.reviewboard.kde.org/r/125388/diff/


Testing
-------


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150925/4e3acf27/attachment.html>


More information about the KDEConnect mailing list