Review Request 125388: do not runtime require Qt 5.5 for no good reason

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125388/#review85917
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Sept. 25, 2015, 8:31 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125388/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 8:31 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Layouts 1.2 appeared in Qt 5.5 [1] and introduced new fooMargin properties
> [2]. We do however not use margins here, so we do not actually need
> Layouts 1.2. Drop back down to Layouts 1.1 to be more compatible with
> mainstream distros.
> 
> [1] http://doc.qt.io/qt-5.4/qtquick-layouts-qmlmodule.html
> [2] http://doc.qt.io/qt-5.5/qml-qtquick-layouts-layout.html#bottomMargin-attached-prop
> 
> 
> Diffs
> -----
> 
>   plasmoid/package/contents/ui/DeviceDelegate.qml bcc4fbc23f6d0058ca32f4be74c836bf76263f21 
> 
> Diff: https://git.reviewboard.kde.org/r/125388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150925/3a474e22/attachment.html>