Review Request 125140: [kdeconnect-kde] initial support for desktop-to-XXX notifications

[David Edmundson]

> On Sept. 10, 2015, 7:08 p.m., Kai Uwe Broulik wrote:
> > Out of curiosity, doesn't KNotification support plugins? At least years ago there was a plugin for sending notifications to your Logitech G15 keyboard.

KNotifcations, yes. But that relies on the sender using KNotification and not any ohter notification lib


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125140/#review85131
-----------------------------------------------------------


On Sept. 10, 2015, 3:41 p.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125140/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 3:41 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Eavesdrop on the Notify call of the org.freedesktop.Notifications dbus-interface, proxy all caught notifications to our peer device and track them in the internal notifications-list.
> 
> Also fix "cancel" requests from peer devices, by cutting of kdeconnect-android's id-prefix.
> 
> 
> Diffs
> -----
> 
>   plugins/notifications/CMakeLists.txt 41c5b78 
>   plugins/notifications/notificationsdbusinterface.h e8d5c2a 
>   plugins/notifications/notificationsdbusinterface.cpp e7b89f2 
>   plugins/notifications/notificationslistener.h PRE-CREATION 
>   plugins/notifications/notificationslistener.cpp PRE-CREATION 
>   plugins/notifications/notificationsplugin.h 7cc67c5 
>   plugins/notifications/notificationsplugin.cpp badb5d3 
> 
> Diff: https://git.reviewboard.kde.org/r/125140/diff/
> 
> 
> Testing
> -------
> 
> I tested with my (patched) tablet, works fine.
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150910/d8800fdb/attachment.html>