Review Request 126129: Yet another notification with media controls for MPRIS plugin

[Sergii Pylypenko]

> On Nov. 21, 2015, 11:34 p.m., Aleix Pol Gonzalez wrote:
> > This looks interesting. Could you provide some screenshots to evaluate the feature?

http://i.imgur.com/dnLlbVC.png
http://i.imgur.com/xmNsiNh.png
http://i.imgur.com/PzCsiQ9.png
http://i.imgur.com/TSrf4XI.png


- Sergii


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126129/#review88685
-----------------------------------------------------------


On Nov. 21, 2015, 6:44 p.m., Sergii Pylypenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126129/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2015, 6:44 p.m.)
> 
> 
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> I've noticed a lamentable absence of the media controls in Android notification area in KDEConnect, which any other music player provides, so I've added this feature, and only then I've noticed the noti-mediacontrol branch.
> So here's my patch, for reference if nothing more.
> The only improvement over the noti-mediacontrol branch it has is that this patch actually compiles. Other than that it's pretty basic - there are buttons Play/Pause, Previos, Next, and the KDEConnect icon to open the multimedia control dialog. It also displays the song name.
> Notification can be enabled or disabled by a checkbox in the multimedia control dialog. The notification will not be created until you open this dialog, but it will stay persistent when you close the app, until you open the multimedia control dialog and disable the checkbox.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml c16b068 
>   res/layout/mpris_control.xml daba05a 
>   res/layout/mpris_control_notification.xml PRE-CREATION 
>   res/values/strings.xml 6281674 
>   res/xml/mprisplugin_preferences.xml c565a35 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 371c2af 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisNotification.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126129/diff/
> 
> 
> Testing
> -------
> 
> Launched KDEConnect on a phone with Android 5.0, clicked all 4 buttons in the notification, clicked checkbox in the multimedia control dialog, watched the song name changing in the notification, everything seemed to work well until my KDE installation bugged out and corrupted all windows (but Plasma did not crash).
> 
> 
> Thanks,
> 
> Sergii Pylypenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20151122/58ba4b37/attachment-0001.html>